search

TooTallNate / ref

Turn Buffer instances into "pointers"
http://tootallnate.github.com/ref
453 stars 141 forks source link

Nan 2 support? #37

Closed justinmchase closed 8 years ago

justinmchase commented 8 years ago

I'm looking at upgrading this project to be compatible with nan2, so I can subsequently upgrade a project that is dependent on this and it is brutally hard. A lot of the apis it relies on appear to be just gone now.

Has there been any talk about upgrading this to Nan2? What are your thoughts in this area.

unbornchikken commented 8 years ago

I don't understand. We've already upgraded it.

TooTallNate commented 8 years ago

Indeed. Try v1.1.0 and report back if you have any issues.

justinmchase commented 8 years ago

:astonished: Very nice. I apparently need to look at the commits before asking questions :)

I just cloned the repo and tried to run the tests, it was crashing but I upgraded to iojs 3.2.0 and worked like a charm. Thanks.