search

TooTallNate / ref

Turn Buffer instances into "pointers"
http://tootallnate.github.com/ref
453 stars 141 forks source link

Broken by V8 6.0 (Node 8.3.0+) #83

Closed MylesBorins closed 6 years ago

MylesBorins commented 7 years ago

It would appear that there are changes to garbage collection, which makes a bunch of sense.

Will dig back into this soon

  1) Object should retain references to written Objects:

      AssertionError [ERR_ASSERTION]: "o" has not been garbage collected
      + expected - actual

      -false
      +true

      at Context.<anonymous> (test/object.js:46:5)

  2) pointer should retain references to a written pointer in a Buffer:

      AssertionError [ERR_ASSERTION]: "child" has not been garbage collected
      + expected - actual

      -false
      +true

      at Context.<anonymous> (test/pointer.js:45:5)
TooTallNate commented 6 years ago

Fixed by https://github.com/TooTallNate/ref/pull/85.