TooTallNate / superagent-proxy

`Request#proxy(uri)` superagent extension
154 stars 46 forks source link

add a CI action with proxy services #49

Closed robbkidd closed 1 year ago

robbkidd commented 1 year ago

This is not a very exciting PR without the workflow approved for running in this repo. Witness the success over in my fork.

TooTallNate commented 1 year ago

Thanks! Seems like CI didn't kick off after merge though. Perhaps something isn't configured correctly in the workflow file?

robbkidd commented 1 year ago

Perhaps something isn't configured correctly in the workflow file?

Perhaps! I'll look into it!

robbkidd commented 1 year ago

Except … it seems it did run on the merged commit, GitHub's just not sprinkling the green check on the commit. 😕

robbkidd commented 1 year ago

Brain dumping how to use Docker for running tests locally in dev.

❯ docker-compose up --detach
❯ docker-compose exec test npm install
❯ docker-compose exec test npm test
# make modifications, repeat install and/or test as appropriate
# when done
❯ docker-compose down

I notice again that the project has a yarn.lock. Those commands could have yarn swapped out for npm. I could update the CI workflow to run yarn instead, if you would prefer, @TooTallNate.