search

Toofifty / easy-blastfurnace

BSD 2-Clause "Simplified" License
2 stars 9 forks source link

Quite a few tweaks and changes #16

Closed hugocowan closed 2 years ago

hugocowan commented 2 years ago

Halloo there. This is not the PR I was talking about earlier, but it's still pretty big. It has some serious changes - I suggest you try this out for yourself before OK-ing it.

There's one more PR after this one, but it's waiting on the next Runelite update.

CHANGELOG

Replaced Deposit Inventory message with relevant message and item highlight for depositing ores or potions.

Added support for the Max Cape as it also provides the goldsmith gauntlets perk.

Fix for coal bag sometimes not showing as empty when it is.

Coal bag step accounts for 36 coal in bag now for GoldHybridMethod if wearing a smithing/max cape.

Added extra step to GoldHybridMethod and GoldMethod to make equipping the goldsmith gauntlets smoother.

Moved equipIceOrSmithsGloves from before collectBars to before waitForBars to encourage equipping them while running to the bars collection point.

Prevented null equipment variable exception.

Updated README to reflect changes.

Updated tests.

ISSUES:

When scrolling up/down in the bank, the outline on items takes a little bit to update. It's not too bad though.

Some of the changes I've made are a bit subjective, it'd be good if you could give the Blast Furnace a go with this and see for yourself if you like them.

hugocowan commented 2 years ago

@Toofifty Please do let me know if you'd like me to do anything else, this PR is all good to merge/release from my perspective.

I've got one more after this PR, I promise it's cool

Toofifty commented 2 years ago

Hey @hugocowan just one final comment, all else LGTM. I can push the new changes through to plugin hub tonight if they're ready

hugocowan commented 2 years ago

@Toofifty Alright, I've done as you requested, hopefully this is good now 🤞