fix(c:afkcheck): change min val to 0

ToogaInc / ToogaBooga

An open-source Realm of the Mad God Discord chat bot designed for advanced cross-verification, moderation, and raid management.

MIT License

8 stars 4 forks source link

fix(c:afkcheck): change min val to 0 #201

Closed nyapat closed 2 years ago

nyapat commented 2 years ago

wasn't really able to get the nitro react to actually show up, but the logic is fine.

thoughts:

what is the point in having both config-dungeons and config-afkchecks have nitro limit configurability?
doesn't one just take precedence over the other anyways?

ewang2002 commented 2 years ago

wasn't really able to get the nitro react to actually show up, but the logic is fine.

If, logically, the nitro reaction isn't supposed to show up if the nitro count is set to 0, then it should be fine.

what is the point in having both config-dungeons and config-afkchecks have nitro limit configurability?

doesn't one just take precedence over the other anyways?

I believe the way I set this is

config-afkchecks lets you set the nitro limit on a section-basis
config-dungeons lets you override the nitro limit for that dungeon across all sections

nyapat commented 2 years ago

wasn't really able to get the nitro react to actually show up, but the logic is fine.

If, logically, the nitro reaction isn't supposed to show up if the nitro count is set to 0, then it should be fine.

not showing up, as in, I wasn't able to get the reaction to appear regardless. probably some config setting I missed, tried finding how to add it but was lost under all the precedence stuff

ewang2002 commented 2 years ago

wasn't really able to get the nitro react to actually show up, but the logic is fine.

If, logically, the nitro reaction isn't supposed to show up if the nitro count is set to 0, then it should be fine.

not showing up, as in, I wasn't able to get the reaction to appear regardless. probably some config setting I missed, tried finding how to add it but was lost under all the precedence stuff

If you're referring to the test server, it's because there is no Nitro role there, as no one has boosted the server

nyapat commented 2 years ago

wasn't really able to get the nitro react to actually show up, but the logic is fine.

If, logically, the nitro reaction isn't supposed to show up if the nitro count is set to 0, then it should be fine.

not showing up, as in, I wasn't able to get the reaction to appear regardless. probably some config setting I missed, tried finding how to add it but was lost under all the precedence stuff

If you're referring to the test server, it's because there is no Nitro role there, as no one has boosted the server

ah, so much for testing that precedence thing then

ewang2002 commented 2 years ago

wasn't really able to get the nitro react to actually show up, but the logic is fine.

If, logically, the nitro reaction isn't supposed to show up if the nitro count is set to 0, then it should be fine.

not showing up, as in, I wasn't able to get the reaction to appear regardless. probably some config setting I missed, tried finding how to add it but was lost under all the precedence stuff

If you're referring to the test server, it's because there is no Nitro role there, as no one has boosted the server

ah, so much for testing that precedence thing then

Precedence should work as expected 😎