search

ToolJet / ToolJet

Low-code platform for building business applications. Connect to databases, cloud storages, GraphQL, API endpoints, Airtable, Google sheets, OpenAI, etc and build apps using drag and drop application builder. Built using JavaScript/TypeScript. 🚀
https://tooljet.com
GNU Affero General Public License v3.0
28.7k stars 3.55k forks source link

Replace Delete link with trash icon and add loading animation(s) #1007

Closed AlexandruValeanu closed 2 years ago

AlexandruValeanu commented 2 years ago

Is your proposal related to a problem?

Follow up from https://github.com/ToolJet/ToolJet/issues/985. Group deletions are a simple Delete link with no progress indication involved.

Describe the solution you'd like

Change the following Delete links to trash icons and add loading state (and/or pop-up to notify that the deletion is ongoing).

https://user-images.githubusercontent.com/11629675/136826814-a03d1e46-10dc-44fe-8c49-ecd983fcaaf5.png

https://user-images.githubusercontent.com/11629675/136827076-16493c4e-3af9-496e-8764-df7eeb826b9a.png

https://user-images.githubusercontent.com/11629675/136827156-07109a83-7cde-41a5-80e4-ac27732efc32.png

Describe alternatives you've considered

If the feature is approved, would you be willing to submit a PR?

Yes, the PR is more or less ready.

luharuka commented 2 years ago

HEY @AlexandruValeanu CAN YOU ASSIGN IT TO ME UNDER TAG HACKTOBERFEST

rutulganatra commented 2 years ago

Hey, Can I work on this issue under hactoberfest label?

AlexandruValeanu commented 2 years ago

It really is the wild west around here. Thanks for the interest but the issue hasn't been approved or discussed yet.

Navaneeth-pk commented 2 years ago

Thanks for creating this issue. Since it is a follow-up issue, assigning it to you. @AlexandruValeanu

@luharuka @rutulganatra Thanks for your interest in contributing to ToolJet but it won't be possible to assign this issue.

luharuka commented 2 years ago

hey @Navaneeth-pk can you tell me in tooljet which issue is for beginners actually no one issue in tooljet is done by me after a lot of searches is this only for professional

Navaneeth-pk commented 2 years ago

We welcome contributions from everyone. To make it easier for the first-time contributors, we have added a label good first issue, these are minor issues that will help you get familiarised with the codebase.

Here is the filter for such issues: https://github.com/ToolJet/ToolJet/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22

Since we are getting a lot of interest during the Hacktoberfest, the number of unassigned issues is very less at the moment.

@luharuka

withshubh commented 2 years ago

Duplicate of https://github.com/ToolJet/ToolJet/issues/985