Closed gkaguirre closed 7 years ago
I think the reason for this is so that an unexpected update of TbTb didn't break the toolbox itself, for example as might happen if the required info from the startup changed. It's possible that the downside of not updating outweighs that upside.
Some options:
a) I think it would be possible to generate a message that indicated that TbTb was out of date and suggesting that it be updated. This would, I think, involve figuring out how to parse output from a command line call to git but probably wouldn't be too hard.
b) We could probably add a preference, settable in startup and also as a key-value pair, that would force an update when tbUse or tbUse project was invoked.
I can look into doing either or both. If I do b), I guess some thought about the right default setting woudl be in order.
DB
From: Geoffrey Aguirre notifications@github.com Reply-To: ToolboxHub/ToolboxToolbox reply@reply.github.com Date: Thursday, March 30, 2017 at 11:19 AM To: ToolboxHub/ToolboxToolbox ToolboxToolbox@noreply.github.com Cc: Subscribed subscribed@noreply.github.com Subject: [ToolboxHub/ToolboxToolbox] Report if local TbTb is behind the current version (#69)
TbTb does not update itself. This can cause users who have not updated their install to have recently produced configurations fail to run properly.
Perhaps TbTb could check if a newer version is available and report this when it is invoked?
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHubhttps://github.com/ToolboxHub/ToolboxToolbox/issues/69, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ABGuZU9_hbdTQeBeC4m1iefeTrr-xNILks5rq8gHgaJpZM4Mug94.
I vote for “a”.
GKA
On Apr 1, 2017, at 2:48 PM, David Brainard notifications@github.com wrote:
I think the reason for this is so that an unexpected update of TbTb didn't break the toolbox itself, for example as might happen if the required info from the startup changed. It's possible that the downside of not updating outweighs that upside.
Some options:
a) I think it would be possible to generate a message that indicated that TbTb was out of date and suggesting that it be updated. This would, I think, involve figuring out how to parse output from a command line call to git but probably wouldn't be too hard.
b) We could probably add a preference, settable in startup and also as a key-value pair, that would force an update when tbUse or tbUse project was invoked.
I can look into doing either or both. If I do b), I guess some thought about the right default setting woudl be in order.
DB
From: Geoffrey Aguirre notifications@github.com Reply-To: ToolboxHub/ToolboxToolbox reply@reply.github.com Date: Thursday, March 30, 2017 at 11:19 AM To: ToolboxHub/ToolboxToolbox ToolboxToolbox@noreply.github.com Cc: Subscribed subscribed@noreply.github.com Subject: [ToolboxHub/ToolboxToolbox] Report if local TbTb is behind the current version (#69)
TbTb does not update itself. This can cause users who have not updated their install to have recently produced configurations fail to run properly.
Perhaps TbTb could check if a newer version is available and report this when it is invoked?
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHubhttps://github.com/ToolboxHub/ToolboxToolbox/issues/69, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ABGuZU9_hbdTQeBeC4m1iefeTrr-xNILks5rq8gHgaJpZM4Mug94. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.
--
Geoffrey Karl Aguirre, M.D., Ph.D. https://cfn.upenn.edu/aguirre Associate Professor of Neurology University of Pennsylvania Philadelphia, PA
TbTb now prints out a message either that the local TbTb is up to date, or that it is not.
I think Nicolas knows how to make text red, and if so I will update so that the not-up-to-date message comes out in a salient red text.
DB
From: Geoffrey Aguirre notifications@github.com Reply-To: ToolboxHub/ToolboxToolbox reply@reply.github.com Date: Thursday, March 30, 2017 at 11:19 AM To: ToolboxHub/ToolboxToolbox ToolboxToolbox@noreply.github.com Cc: Subscribed subscribed@noreply.github.com Subject: [ToolboxHub/ToolboxToolbox] Report if local TbTb is behind the current version (#69)
TbTb does not update itself. This can cause users who have not updated their install to have recently produced configurations fail to run properly.
Perhaps TbTb could check if a newer version is available and report this when it is invoked?
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHubhttps://github.com/ToolboxHub/ToolboxToolbox/issues/69, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ABGuZU9_hbdTQeBeC4m1iefeTrr-xNILks5rq8gHgaJpZM4Mug94.
I've pulled the changes and can confirm that TbTb reports that it is running the most recent version. It is a trickier matter to test if it successfully detects that it has fallen a version behind...
I pushed a small change this morning (text will be red if you're out of sync).
So you should see a (not red) message if you do a tbUse now, and it should go away when you pull.
Closing.
TbTb does not update itself. This can cause users who have not updated their install to have recently produced configurations fail to run properly.
Perhaps TbTb could check if a newer version is available and report this when it is invoked?