search

Toolify / Backbone

A new file manager for Android 4.0+
Other
2 stars 3 forks source link

Picker breadcrumbs missing #50

Closed BrandoCommando closed 11 years ago

BrandoCommando commented 11 years ago

When using the picker (I just go into Youtube, and hit upload and select Backbone), it looks like the breadcrumbs are blank. The outer view is there, and the level indicators show up when you navigate, but the path itself is not populated. Also, we can probably hide the dynamic lock icon thing when using Picker.

bkensey commented 11 years ago

The problem is that the breadcrumb uses the white text from the main app while the picker still uses the same CM white background. If you look really hard, you can make them out. We need to make some decisions about the picker dialog theme (holo light or light w/ dark action bar?), and then I can fix it.

I half agree with the removal of the dynamic lock icon, but CM put it there as a filesystem picker (When the user has more than one storage device mounted). The lock doesn't communicate useful information, because a picker is fully read-only. Can you think of any situation where a file chosen from the picker would be opened for editing?

BrandoCommando commented 11 years ago

I guess it does provide drive switching functionality, but its not super obvious. Have we discussed changing the icon to the drive icon before? Back to the text. Can we not just set the background color of the breadcrumbs?

bkensey commented 11 years ago

For now all breadcrumb views pull from a single style, so they all look the same. In the dev-info-drawer pull request, I ended up needing to wrap the picker breadcrumb view with a linear layout, so I just set a dark background color on that. The Picker style still needs to be fixed, but at least it's usable for now.