search

Toolify / Backbone

A new file manager for Android 4.0+
Other
2 stars 3 forks source link

Switch from Otto to EventBus for our bus needs #90

Closed bkensey closed 10 years ago

bkensey commented 10 years ago

Bits of code cleanup in tow. Mostly formatting and comment improvements.

bkensey commented 10 years ago

Ready for merge, pending positive review.

BrandoCommando commented 10 years ago

Code looks simple enough. onEvent replaces individual instances with overloaded parameters. I didn't have any issues with Otto, but have none with GreenRobot's implementation either.

bkensey commented 10 years ago

Yeah, the two serve identical purposes. The switch provides us with speed improvements, although I don't think we use enough events to make the boost significant, and gives us sticky events. I think stickies are the bit I'm most interested in, as they allow subscribing components to check for an existing sticky event while they're loading.