search

ToolkitForDart / darttoolkit-extension

Toolkit for Dart for Adobe Flash Professional: sources
http://toolkitfordart.github.io
32 stars 11 forks source link

import 'dart:html' as html; - unused import #8

Closed avstudios closed 11 years ago

avstudios commented 11 years ago

Does the lib need import html library? it's highlighted as unused import.

bp74 commented 11 years ago

Hi,

Is is highlighted in the StageXL library or in your project? If you don't access any of the html classes or functions you can safely remove it. In which file do you see the warning?

Bernhard

avstudios commented 11 years ago

Sorry for not being clear. It's in StageXL Dart library. I publish to the lib using the Toolkit for Dart quite often and I would prefer not to remove the import line manually every time I have a new version.

bp74 commented 11 years ago

Oh sorry now i understand. For some reason i thought this question is related to the StageXL repository. I think Philippe has to take a look at it.

elsassph commented 11 years ago

You're right, it should be removed.

avstudios commented 11 years ago

I've updated Exporter.jsfl myself. I have new branch and If you give me an access to your repo I could push it there.

elsassph commented 11 years ago

Well do a Pull request of your fork.

On Fri, Sep 27, 2013 at 9:59 AM, avstudios notifications@github.com wrote:

I've updated Exporter.jsfl myself. I have new a new branch and If you give me an access to your repo I could push it there.

— Reply to this email directly or view it on GitHubhttps://github.com/ToolkitForDart/darttoolkit-extension/issues/8#issuecomment-25231599 .

Philippe