ToontownRewritten / api-doc

Documentation of Toontown Rewritten's Web APIs for developers.
https://toontownrewritten.com/
49 stars 7 forks source link

Invasions API including extra characters in cog name #3

Closed dansage closed 9 years ago

dansage commented 9 years ago

I just noticed that the invasion API includes an extra character \u0003 in the middle of the cog name when Telemarketers are invading. It's easy enough to filter out on my end, but, looking back, it seems to be a long-standing issue (at least a month when I started keeping track of responses).

Example:

{
  "lastUpdated": 1416509221,
  "invasions": {
    "Acrylic Acres": {
      "asOf": 1416509218,
      "type": "Tele\u0003marketer",
      "progress": "5939/7300"
    }
  },
  "error": null
}
jjkoletar commented 9 years ago

This is the Panda3D "text-soft-hyphen-key" used in in-game localizations https://github.com/panda3d/panda3d/blob/master/panda/src/text/config_text.cxx#L115-L118

dansage commented 9 years ago

Oh so instead of filtering them out I should change them to hypens? I've never actually looked at any Panda3D-related stuff before so I never would have thought to check there!

jjkoletar commented 9 years ago

If you break the text across multiple lines, you should put a hyphen there. For example:

Telemarketer
Tele-
marketer
Telemark
eter
dansage commented 9 years ago

Oh I see, that'd be the soft part I guess.

It might be a good idea to add a little note about that to the information by the type property. Thanks for the explanation as-is, though!