search

ToothlessGear / node-gcm

A NodeJS wrapper library port to send data to Android devices via Google Cloud Messaging
https://github.com/ToothlessGear/node-gcm
Other
1.31k stars 206 forks source link

Support in UTF-8 ? Hebrew Characters? Emoticons? #112

Closed shaharlinial closed 9 years ago

shaharlinial commented 9 years ago

I can't get Hebrew characters sent with this package.

Is this an issue? is this a known issue?

hypesystem commented 9 years ago

It is not a known issue, but also not something I have tested.

I find it likely that it has more to do with serialization/deserialization than this actual library. Do you have some example code you can share? (In fact, both server-side and client-side would be interesting in this case.)

shaharlinial commented 9 years ago

I can confirm that node-gcm + request support Hebrew characters without any special modifications. The issue was caused by other library that didn't know how to handle payload in hebrew without encodeURIComponent, however node-gcm and request doesn't need encodeURIComponent to deliver a message in Hebrew.

Very well written @hypesystem .

hypesystem commented 9 years ago

Great! Thank you for your time :) I am glad you got your issue resolved.