search

ToothlessGear / node-gcm

A NodeJS wrapper library port to send data to Android devices via Google Cloud Messaging
https://github.com/ToothlessGear/node-gcm
Other
1.31k stars 206 forks source link

Fix issue when using module behind a proxy #115

Closed pablonazareno closed 8 years ago

pablonazareno commented 9 years ago

Add flag for old proxy usage when making request to google GCM with request module. Fix issue #97

hypesystem commented 9 years ago

Nice -- very simple fix!

Would it be possible to write a test that fails with the old code but passes after this fix?

pablonazareno commented 9 years ago

Other solution is use version 2.40.0 of request module at package.json This version is previous to proxy changes.

hypesystem commented 9 years ago

I prefer the solution where we can use the latest version of request.

I find it very interesting that they introduced breaking changes in a minor version bump.

The commit that broke it on our side is this one: https://github.com/ToothlessGear/node-gcm/commit/ad651d5a54f200c558120b4d1a163a6287b4d5af

I would still like to see some kind of test of this functionality, proving what is fixed :)

eladnava commented 8 years ago

Closed due to #189 which fixes the real cause of the proxy problem.