search

ToothlessGear / node-gcm

A NodeJS wrapper library port to send data to Android devices via Google Cloud Messaging
https://github.com/ToothlessGear/node-gcm
Other
1.31k stars 206 forks source link

Use `files` in package.json #116

Closed SimenB closed 9 years ago

SimenB commented 9 years ago

This avoids getting test-files when installing the package

hypesystem commented 9 years ago

Nice! Don't forget to add yourself to the list of collaborators in package.json and the README.

SimenB commented 9 years ago

@hypesystem Updated.

I noticed that license was missing from package.json, so I ran npm init to add missing fields. It also shortened the form in contributors. Want me to change back?

hypesystem commented 9 years ago

@SimenB the collaborators stuff is fine. I would like a cross-platform (linux/osx/windows) solution for npm test, though.

In Windows, the one you have changed it to, requires manually changing PATH.

SimenB commented 9 years ago

npm run is supposed to handle that... I have a window box at home, I'll give it a whack tonight.

SimenB commented 9 years ago

Of course, I can remove the changes to test and make a separate PR

hypesystem commented 9 years ago

I think it would be good to make that a separat PR -- so I can merge this asap :)

SimenB commented 9 years ago

Sure, I'll fix it tonight

SimenB commented 9 years ago

@hypesystem Removed test stuff, see #117

hypesystem commented 9 years ago

Thank you!