Closed bastienleonard closed 8 years ago
Seeing as you are changing the possible contents of the second parameter of send, I think it would be fitting to rename it registrationIds -> recipient
(likewise, originalRegIds -> originalRecipient
). This makes clearer what the variable contains.
It looks good, and it would be nice to support this in sendNoRetry
.
Remember to add tests for sending to topics, update the README, and add yourself to the contributors in package.json.
sendNoRetry()
registrationIds
to recipient
That's all for today. I just realized that I should probably add support for notificationKey
.
Looks really good! I had a few comments. Other than that I see the following things missing:
notificationKey
support (as you suggest)Thank you so much for your time :)
recipient.notificationKey
(Will update the readme and contributors list after work, if you're OK with the changes)
Looks good :) Let me know when you've updated README and contributors, and I will merge :)
{ registrationIds: [...] }
), not sure what's your take on this.Looks good :) I think the explicit recipient-type is the best model until we make a breaking change, so we should encourage that in the README.
Just now released in 0.12.0
Following issue #146:
This is a quick fix for sending to a topic with
send()
:If it looks good enough, I'll add support for the same parameters for
sendNoRetry()
.