Depricated registration id

[minal2709]

Hey,

I see GCM has deprecated the registration ids. It uses tokens instead. This lib requires an update?

[hypesystem]

I am not sure I quite follow. According to the server ref Notification Keys are deprecated, but the registration_ids field is not. We support all of the available key types at the moment (topics, registration ids, notification keys).

[eladnava]

Google decided to rename the registration IDs in their documentation to registration tokens, which actually makes a lot more sense. However, they did leave the registration_ids parameter in the GCM API intact: https://developers.google.com/cloud-messaging/http-server-ref

registration_ids (String array) - This parameter specifies a list of devices (registration tokens, or IDs) receiving a multicast message. It must contain at least 1 and at most 1000 registration tokens.

If you wanted, you could update the docs and rename the IDs to tokens, but that's not really that important.

[hypesystem]

I think updating the docs would be great. There is the one issue of the named registrationIds argument we use. There should probably be an alias: registrationTokens.

[eladnava]

@hypesystem Good point. Here's what I'm planning to do:

• Update the docs, replacing the registration IDs terminology with registration tokens, as per the updated GCM docs
• Create an alias for registrationTokens, to maintain backward compatibility (by adding the alias to the validKeys array in sender.js#L29)
• Update the docs to promote use of the registrationTokens parameter

What do you think?

[hypesystem]

:+1:

[eladnava]

@hypesystem Done. :+1:

[eladnava]

@hypesystem this can be closed.