search

ToothlessGear / node-gcm

A NodeJS wrapper library port to send data to Android devices via Google Cloud Messaging
https://github.com/ToothlessGear/node-gcm
Other
1.3k stars 206 forks source link

iOS Support (update the docs) #166

Closed eladnava closed 8 years ago

eladnava commented 8 years ago

I think we should update the docs and repository description, as node-gcm does support iOS notifications via GCM, but the description is misleading, as it only mentions Android.

Repo description:

A NodeJS wrapper library port to send data to Android devices via Google Cloud Messaging https://github.com/ToothlessGear/node-gcm

README.md:

node-gcm is a Node.JS library for Google Cloud Messaging for Android, which replaces Cloud 2 Device Messaging (C2DM).

Also, not sure that the C2DM part is relevant anymore. Can I submit a pull request to modify the docs as follows?

node-gcm is a Node.JS library for Google Cloud Messaging.

Anything else we'd like to add in the main description?

hypesystem commented 8 years ago

I think that would be a fine PR. Unfortunately only @ToothlessGear has access to the description of the library at the moment, so we'd need him to update it :-)

eladnava commented 8 years ago

Excellent, created a PR - #168 @hypesystem