search

ToothlessGear / node-gcm

A NodeJS wrapper library port to send data to Android devices via Google Cloud Messaging
https://github.com/ToothlessGear/node-gcm
Other
1.3k stars 206 forks source link

Add capability to set strictSSL. #173

Closed marcobrador closed 8 years ago

marcobrador commented 8 years ago

Hello,

I have added a field in the "options" object to set "strictSsl" to false. This comes in handy when behind a corporate firewall with an invalid certificate. :)

Hope you find this useful and gets integrated in the project!

Regards, Marc

hypesystem commented 8 years ago

Hey! Sorry for the long response time on this, it somehow went missing :) Your code + tests look great!

Could I get you to update the README so the option is shown to outside users?

Also remember to add yourself to the contributors in package.json!

Thank you for your contribution! :smile:

marcobrador commented 8 years ago

Hi, thanks for your comments, appreciate it.

Where do you want me to document the usage of such option? In the code snippets of the README I see no example of using the "options" field in the constructor... Maybe we could create a table with all the available options or something like this, just let me know how you prefer it. Marc

hypesystem commented 8 years ago

Hmm... you are right, we currently don't document the options we support. Let's just leave that out. I've created a separate issue for that: #178

Just add yourself as a contributor in package.json and we're golden, good to merge :)

marcobrador commented 8 years ago

Done!

hypesystem commented 8 years ago

Thank you very much for your contribution! Greatly appreciated!

eladnava commented 8 years ago

@marcobrador Note that the parameter strictSsl has been renamed to strictSSL due to #184.