Closed hypesystem closed 8 years ago
@hypesystem Am I right that these are the currently-available options?
if (this.options && this.options.proxy) {
post_options.proxy = this.options.proxy;
}
if (this.options && this.options.maxSockets) {
post_options.maxSockets = this.options.maxSockets;
}
var timeout = Constants.SOCKET_TIMEOUT;
if (this.options && this.options.timeout) {
timeout = this.options.timeout;
}
post_options.timeout = timeout;
if (this.options && typeof(this.options.strictSsl) == "boolean") {
post_options.strictSSL = this.options.strictSsl;
}
That is correct. See also #179, which discusses changing the behaviour to allow all options that are allowed in request
. This would make the documentation much simpler: we would just refer to request
's documentation.
@hypesystem Excellent. Making it possible to override any request option is great. Let's see what the outcome of #179 is, and then we can figure out how to properly document the request params.
Yes :)
We should document somewhere the options that can be given to the sender on creation https://github.com/ToothlessGear/node-gcm/blob/master/lib/sender.js#L5