ToothlessGear / node-gcm

A NodeJS wrapper library port to send data to Android devices via Google Cloud Messaging
https://github.com/ToothlessGear/node-gcm
Other
1.3k stars 206 forks source link

Allow setting all request options #184

Closed eladnava closed 8 years ago

eladnava commented 8 years ago

As discussed in #179, we'd like developers to be able to set all request options externally, by providing an object to the gcm.Sender() constructor, such as the request proxy, timeout, strictSSL, etc.

Changes:

Checked and works. Ran npm test successfully. External options do not override (except timeout and new headers)

Closes #179.

hypesystem commented 8 years ago

Just beautiful! Great job :) --- had one comment

eladnava commented 8 years ago

@hypesystem Fixed. Thanks for the comment! :)