Closed eladnava closed 8 years ago
@hypesystem fyi
@hypesystem Fixed, thanks!
Very good update :+1: good with some better tests. We could decide to leave the considerations in https://github.com/ToothlessGear/node-gcm/pull/190#commitcomment-15202646 for a later PR, if you wish, but it would also fit in here.
@hypesystem I agree that we should be checking for multiple recipient keys and erroring out in that case.
I think that we should not be using the Array.prototype.foreach()
traversal method in extractRecipient()
, because we can't return
out of the function easily. Therefore, I have reverted to the good old for(var i in array)
and will be pushing the commits in a few.
@hypesystem Implemented the multiple recipient error logic.
@hypesystem We good to merge? =)
Absolutely :smile:
Closes #186.
Returns an error to the callback in the following circumstances:
In addition: