ToothlessGear / node-gcm

A NodeJS wrapper library port to send data to Android devices via Google Cloud Messaging
https://github.com/ToothlessGear/node-gcm
Other
1.3k stars 208 forks source link

GCM server #206

Closed roccomuso closed 8 years ago

roccomuso commented 8 years ago

Wouldn't be useful to have also the possibility to start a server that listen and saves the users' Token?

hypesystem commented 8 years ago

It sure would! Unfortunately, in reality, there are many other requirements than just blindly saving users' requirements. Most app developers will want some sort of authentication or other vetting process of users claiming to be using their app before sending them notifications.

A simple server like that would be great to have as an example implementation, though.

I am thinking it should probably be a separate project, using node-gcm on the inside. What do you think?

roccomuso commented 8 years ago

@hypesystem yeah definetly should be a new project, I can work on that, should I fork or create a new repo?

hypesystem commented 8 years ago

I think it sounds like a great opportunity for a new repository using node-gcm as a dependency :smile:

roccomuso commented 8 years ago

Working on it ;) I'll show you something soon.

roccomuso commented 8 years ago

@hypesystem I sticked to the original repo, so i thought better fork than create a whole new repo. Check it out: https://github.com/roccomuso/node-gcm

hypesystem commented 8 years ago

I am going to close this issue because it is not an issue with node-gcm.

It looks like a very interesting project, building a simple server for node-gcm.

I don't see any reason to fork from node-gcm, though --- all of your dependencies on node-gcm are using the public interface, so a wrapping project would be a neater solution imo: I think you should create a new repository specifically for the server :smile:

roccomuso commented 8 years ago

@hypesystem new repo done: https://github.com/roccomuso/gcm-server

eladnava commented 8 years ago

@roccomuso Good job! Looks pretty cool. Well done moving it to its own repo, I agree that it's better that way.

hypesystem commented 8 years ago

Looks good! :+1: