search

ToothlessGear / node-gcm

A NodeJS wrapper library port to send data to Android devices via Google Cloud Messaging
https://github.com/ToothlessGear/node-gcm
Other
1.3k stars 208 forks source link

fixing indentation in a line inside senderSpec #212

Closed chirag200666 closed 8 years ago

chirag200666 commented 8 years ago

I got confused when I read the line as it was my first time working with node js tests.

hypesystem commented 8 years ago

Interesting! I have not noticed this before now, but the two lines in the tests saying if should be changed to say it. Can I get you to do that, too?

chirag200666 commented 8 years ago

@hypesystem done.

hypesystem commented 8 years ago

Thanks :smile:

chirag200666 commented 8 years ago

@hypesystem the second case which was changed from if to it, which starts from line 125 is failing. Can you have a look at it. Should I create a new issue for the same ?

hypesystem commented 8 years ago

That should be a new issue :smile:

chirag200666 commented 8 years ago

Created, thanks :smile: