search

ToothlessGear / node-gcm

A NodeJS wrapper library port to send data to Android devices via Google Cloud Messaging
https://github.com/ToothlessGear/node-gcm
Other
1.3k stars 208 forks source link

Migrate from GCM to FCM #232

Closed AlexAmin closed 8 years ago

AlexAmin commented 8 years ago

Updated the request url

hypesystem commented 8 years ago

Can you link to where they announced the new URL?

I don't think we should change the debug tag, but other than that it looks like a fine PR.

Don't forget to ADF yourself to contributors :smile:

Thanks!

AlexAmin commented 8 years ago

It's right here https://firebase.google.com/docs/cloud-messaging/downstream#sending_topic_messages_from_the_server :)

I changed the debug tag because I renamed the project to node-fcm. According to this page no new features will be added to gcm, only to fcm. https://developers.google.com/cloud-messaging/faq

eladnava commented 8 years ago

They just keep rebranding the API every Google I/O =)

First, it was C2DM - that is indeed a bad name. Then came GCM. And now FCM? When will they be satisfied? =P

Anyway, someone went ahead and already grabbed both the fcm and node-fcm NPM packages: https://www.npmjs.com/package/fcm https://www.npmjs.com/package/node-fcm

So renaming the package would be a little problematic.

govardhanaraoganji commented 8 years ago

rebranding its true ;) and added few response param.

Please have look into it https://firebase.google.com/docs/cloud-messaging/server#response

hypesystem commented 8 years ago

@AlexAmin could you roll back the change to sender.js and add yourself to contributors? Then I'll merge.

We should create a separate issue for the new parameters.

hypesystem commented 8 years ago

Hey Alex -- didn't see your updates, but they look great :-)

In the future, if you want to notify people of new changes in a PR you need to comment on it :smile:

Thanks for the effort!