search

ToothlessGear / node-gcm

A NodeJS wrapper library port to send data to Android devices via Google Cloud Messaging
https://github.com/ToothlessGear/node-gcm
Other
1.3k stars 208 forks source link

Typo in exports #258

Closed bbqsrc closed 7 years ago

bbqsrc commented 8 years ago

MulitcastResult -> MulticastResult

eladnava commented 8 years ago

Nice catch!

@hypesystem Can we merge?

hypesystem commented 8 years ago

This would be a breaking change. We need to also support the wrongly spelled version, in case anyone relies on it.

With v1 we will remove MulticastResult altogether.

@bbqsrc also remember to add yourself to contributors :)

eladnava commented 8 years ago

Ah, right. So I guess we should wait for v1 to be completed and merged.

hypesystem commented 8 years ago

There are two options, as I see it. I don't have a preference.

  1. Do nothing about this for now, as it will go away with v1.
  2. Fix it in the master branch, remembering to keep backwards compatibility (ie. supporting both names).
eladnava commented 8 years ago

I'd say option 1 makes more sense.