search

ToothlessGear / node-gcm

A NodeJS wrapper library port to send data to Android devices via Google Cloud Messaging
https://github.com/ToothlessGear/node-gcm
Other
1.3k stars 208 forks source link

Support for ios mutable-content #297

Closed SemonCat closed 7 years ago

SemonCat commented 7 years ago

FCM added the mutable_content field to API

see https://github.com/firebase/quickstart-ios/issues/70 for more detail

eladnava commented 7 years ago

@SemonCat Looks good, however, can you write some tests, please? Check that the parameter is set successfully and sent to the FCM API and setting it to something other than a boolean is invalid.

Thanks!

SemonCat commented 7 years ago

HI, @eladnava ,

Sorry, I only add mutable_content to json check,

Is your master branch check arguments type?

I pass string to contentAvailable and it didn't block it.

eladnava commented 7 years ago

OK thanks @SemonCat I think that's good. It looks like at this time we don't validate the message parameters' types.

Can we merge @hypesystem?

SemonCat commented 7 years ago

Hi, @eladnava ,

Sorry to bother you,

but I really need this option for fcm push.

any thing I can do to speeding up merge?

eladnava commented 7 years ago

I will go ahead and merge since the tests pass and this looks good to me. Let me know when you get a chance to look at it @hypesystem.

eladnava commented 7 years ago

Released 0.14.6 on npm. 👍

SemonCat commented 7 years ago

Hi, @eladnava ,

Thanks for your help!👍

hypesystem commented 7 years ago

It looks fine to me :-)