ToothlessGear / node-gcm

A NodeJS wrapper library port to send data to Android devices via Google Cloud Messaging
https://github.com/ToothlessGear/node-gcm
Other
1.3k stars 206 forks source link

Pass on recipient FCM param name from extractRecipient #312

Closed eladnava closed 6 years ago

eladnava commented 6 years ago

Closes #278. All tests pass.

eladnava commented 6 years ago

@hypesystem

eladnava commented 6 years ago

@hypesystem Thanks! I agree, it could definitely be simplified, maybe by moving its logic to getRequestBody() in v1.

hypesystem commented 6 years ago

Sorry, I completely forgot this. Let's get it out :-)

hypesystem commented 6 years ago

Landed in 0.14.9

eladnava commented 6 years ago

Excellent 👍