search

ToothlessGear / node-gcm

A NodeJS wrapper library port to send data to Android devices via Google Cloud Messaging
https://github.com/ToothlessGear/node-gcm
Other
1.3k stars 208 forks source link

Notice on FCM migration deadline #317

Closed hypesystem closed 6 years ago

hypesystem commented 6 years ago

Google announced today that by April 11, 2019, all users must have migrated off gcm to fcm. I have added a notice to the README to make it clear that we already support this migration.

Thoughts, @eladnava ?

eladnava commented 6 years ago

@hypesystem Looks perfect.

It's a shame that we can't rebrand node-gcm as it kinda gives off the assumption that if you use this package you are essentially using a deprecated library that connects to GCM.

Not much else we can do I think, except actually renaming the package (node-fcm is taken as you know).

hypesystem commented 6 years ago

Both fcm and node-fcm are taken by unmaintained forks of our lib, which kind of sucks. Maybe we could contact them and consolidate the packages?

(They have < 200 downloads last 7 days combined, we have 33000.)

eladnava commented 6 years ago

@hypesystem Both of these packages were published by the same person and the underlying code is not a fork of our lib, he wrote his own thing: https://github.com/aknoormohamed/node-fcm/blob/master/lib/fcm.js

hypesystem commented 6 years ago

Ah... I just saw similarities in the interface but I see it is very different from ours...

Anyway, will merge this. I don't know what to do with the name...

eladnava commented 6 years ago

We can go for something else like firebase-cloud-messaging or think of another variation? https://www.npmjs.com/package/firebase-cloud-messaging

eladnava commented 6 years ago

And there's always the option of getting in contact with aknoormohamed to see if he would be interested in transferring ownership of the packages: https://github.com/aknoormohamed/node-fcm/commits?author=aknoormohamed