search

ToothlessGear / node-gcm

A NodeJS wrapper library port to send data to Android devices via Google Cloud Messaging
https://github.com/ToothlessGear/node-gcm
Other
1.3k stars 208 forks source link

Update dependencies #318

Closed eladnava closed 6 years ago

eladnava commented 6 years ago 
 lodash      ^3.10.1  →  ^4.17.10 
 request      2.81.0  →    2.85.0 
 mocha        ^2.2.4  →    ^5.1.1 
 proxyquire   ^1.4.0  →    ^2.0.1 
 sinon       ^1.14.1  →    ^5.0.7

Only one devDependency has not been updated, chai, as updating it breaks about 25 tests. Minimum Node version 4.0 mentioned in README. Version bumped to 1.0.0.

npm audit returns:

[+] no known vulnerabilities found [130 packages audited]

Closes #106.

@hypesystem Looks good?

hypesystem commented 6 years ago

Great :smile: we should probably work on getting chai updated, too, at some point.

Will you npm publish?

jkowalleck commented 6 years ago

Looks like engines was not updated in package.json. I am on mobile, maybe I am just not having the right view.

hypesystem commented 6 years ago

You are right, @jkowalleck !

@eladnava will you update the engines part before publishing?

jkowalleck commented 6 years ago

Thank you for your work, @eladnava and @hypesystem

eladnava commented 6 years ago

@jkowalleck Thank you! 👍 @hypesystem Published 1.0.0 to npm.

eladnava commented 6 years ago

Ah crap, didn't see your comments about the engines directive. Updated it and published 1.0.1.

hypesystem commented 6 years ago

Better late than never :smile: integers are cheap :fireworks: