search

ToothlessGear / node-gcm

A NodeJS wrapper library port to send data to Android devices via Google Cloud Messaging
https://github.com/ToothlessGear/node-gcm
Other
1.3k stars 208 forks source link

Adding `smallIcon` and `largeIcon` set exeptions #331

Closed verybluebot closed 5 years ago

verybluebot commented 5 years ago

On android its possible to set smallIcons and largeIcon see details in issue #330 have not test natively with setting same on notification when tested on React Native library it did not worked

hypesystem commented 5 years ago

Hmm, looking at the actual documentation (which is fine!) it seems that this might actually be a problem with react-native-push-notification's interpretation of notifications, rather than actually a part of the GCM specification...

The hint to me is that it uses the data object, which is just for any arbitrary data according to the official spec.

I think these two fields should be documented in react-native-push-notification instead.

eladnava commented 5 years ago

Agree with @hypesystem, please read more here: https://github.com/ToothlessGear/node-gcm/issues/330#issuecomment-453290279

Thanks for the PR! 👍

verybluebot commented 5 years ago

@hypesystem ok agreed