Add fcm_options as allowed params to message object

ToothlessGear / node-gcm

A NodeJS wrapper library port to send data to Android devices via Google Cloud Messaging

https://github.com/ToothlessGear/node-gcm

Other

1.3k stars 208 forks source link

Closed SpellChucker closed 4 years ago

SpellChucker commented 4 years ago

As per the Firebase docs, fcm_options is a new-ish parameter to allow setting a label on push notification messages. The message options does not have this as a valid config so setting it on the message will be ignored. This will allow it as a valid option.

eladnava commented 4 years ago

Thanks for your PR @SpellChucker!

Would you mind documenting this parameter in the README under Additional message options?

SpellChucker commented 4 years ago

Updated! Thanks @eladnava

eladnava commented 4 years ago

@SpellChucker Awesome, thanks!

Looks good to me. Merged! 💯