ToothlessGear / node-gcm

A NodeJS wrapper library port to send data to Android devices via Google Cloud Messaging
https://github.com/ToothlessGear/node-gcm
Other
1.3k stars 208 forks source link

Make send URI configurable #344

Closed pertu closed 3 years ago

pertu commented 4 years ago

Send URI is hard-coded in Constants.GCM_SEND_URI.
Ability to set custom uri via Sender options may help with integration testing (using mock GCM endpoint).

hypesystem commented 4 years ago

This sounds like a great idea! If you want to do a PR for this we're very open for it :smile: I'm thinking an option could override the default.