search

ToothlessGear / node-gcm

A NodeJS wrapper library port to send data to Android devices via Google Cloud Messaging
https://github.com/ToothlessGear/node-gcm
Other
1.3k stars 206 forks source link

move callback outside of try catch block #35

Closed jaclar closed 11 years ago

jaclar commented 11 years ago

Fixes issue #34 If there is an exception within the callback the try-catch block will catch the exception and call the callback a second time, this time with an unrelated error. Moving the callback outside of the try-catch block solves this issue.

ToothlessGear commented 11 years ago

you're awesome, thanks

2fours commented 11 years ago

any chance of an npm update?

On 11/5/13, Marcus Farkas notifications@github.com wrote:

you're awesome, thanks

Reply to this email directly or view it on GitHub: https://github.com/ToothlessGear/node-gcm/pull/35#issuecomment-27820692

2fours commented 11 years ago

nm looks like you've done it, sweet. :)