search

ToothlessGear / node-gcm

A NodeJS wrapper library port to send data to Android devices via Google Cloud Messaging
https://github.com/ToothlessGear/node-gcm
Other
1.3k stars 206 forks source link

Deprecate `addData*` #88

Closed hypesystem closed 9 years ago

hypesystem commented 9 years ago

Deprecate Message#addDataWithObject and Message#addDataWithKeyValue.

Both of these are now covered by Message#addData (and will be removed in v1).

They should probably print something to console.warn or something.

ToothlessGear commented 9 years ago

Additionally I'd suggest to write in the README that those are deprecated, or remove them entirely to avoid more confusion as I've read in the other issue #70

hypesystem commented 9 years ago

Added it to the changelog. Seeing as they aren't referenced anywhere else in the README, I think we are safe :)