Open ValorHeart opened 4 years ago
Hello, Please review the below code and consider adding it to the difido-testng project. File: RemoteDifidoReporter (Line 97) if (difidoConfig.getPropertyAsBoolean(RemoteDifidoOptions.USE_PROXY)) { String proxyHost = difidoConfig.getPropertyAsString(RemoteDifidoOptions.PROXY_HOST); int proxyPort = difidoConfig.getPropertyAsInt(RemoteDifidoOptions.PROXY_PORT); String proxyUserName = difidoConfig.getPropertyAsString(RemoteDifidoOptions.PROXY_USERNAME); String proxyPassword = difidoConfig.getPropertyAsString(RemoteDifidoOptions.PROXY_PASSWORD); client = new DifidoClient(host, port, proxyHost, proxyPort, proxyUserName, proxyPassword); } else { client = new DifidoClient(host, port); }
if (difidoConfig.getPropertyAsBoolean(RemoteDifidoOptions.USE_PROXY)) {
String proxyHost = difidoConfig.getPropertyAsString(RemoteDifidoOptions.PROXY_HOST);
int proxyPort = difidoConfig.getPropertyAsInt(RemoteDifidoOptions.PROXY_PORT);
String proxyUserName = difidoConfig.getPropertyAsString(RemoteDifidoOptions.PROXY_USERNAME);
String proxyPassword = difidoConfig.getPropertyAsString(RemoteDifidoOptions.PROXY_PASSWORD);
client = new DifidoClient(host, port, proxyHost, proxyPort, proxyUserName, proxyPassword);
}
else {
client = new DifidoClient(host, port);
File: DifidoClient (Line 32) public DifidoClient(String host, int port, String proxyHost, int proxyPort, String proxyUserName, String proxyPassword) { baseUri = String.format(BASE_URI_TEMPLATE, host, port); client = new HttpClient(); Credentials credentials = new UsernamePasswordCredentials(proxyUserName, proxyPassword); AuthScope authScope = new AuthScope(proxyHost, proxyPort); client.getState().setProxyCredentials(authScope, credentials); }
public DifidoClient(String host, int port, String proxyHost, int proxyPort, String proxyUserName, String proxyPassword) {
baseUri = String.format(BASE_URI_TEMPLATE, host, port);
client = new HttpClient();
Credentials credentials = new UsernamePasswordCredentials(proxyUserName, proxyPassword);
AuthScope authScope = new AuthScope(proxyHost, proxyPort);
client.getState().setProxyCredentials(authScope, credentials);
File: RemoteDifidoConfig (Line 26) USE_PROXY("use.proxy", "false"), PROXY_HOST("proxy.host", ""), PROXY_PORT("proxy.port", ""), PROXY_USERNAME("proxy.username", ""), PROXY_PASSWORD("proxy.password", "");
USE_PROXY("use.proxy", "false"),
PROXY_HOST("proxy.host", ""),
PROXY_PORT("proxy.port", ""),
PROXY_USERNAME("proxy.username", ""),
PROXY_PASSWORD("proxy.password", "");
Hello, Please review the below code and consider adding it to the difido-testng project. File: RemoteDifidoReporter (Line 97)
if (difidoConfig.getPropertyAsBoolean(RemoteDifidoOptions.USE_PROXY)) {
String proxyHost = difidoConfig.getPropertyAsString(RemoteDifidoOptions.PROXY_HOST);
int proxyPort = difidoConfig.getPropertyAsInt(RemoteDifidoOptions.PROXY_PORT);
String proxyUserName = difidoConfig.getPropertyAsString(RemoteDifidoOptions.PROXY_USERNAME);
String proxyPassword = difidoConfig.getPropertyAsString(RemoteDifidoOptions.PROXY_PASSWORD);
client = new DifidoClient(host, port, proxyHost, proxyPort, proxyUserName, proxyPassword);
}
else {
client = new DifidoClient(host, port);
}
File: DifidoClient (Line 32)
public DifidoClient(String host, int port, String proxyHost, int proxyPort, String proxyUserName, String proxyPassword) {
baseUri = String.format(BASE_URI_TEMPLATE, host, port);
client = new HttpClient();
Credentials credentials = new UsernamePasswordCredentials(proxyUserName, proxyPassword);
AuthScope authScope = new AuthScope(proxyHost, proxyPort);
client.getState().setProxyCredentials(authScope, credentials);
}
File: RemoteDifidoConfig (Line 26)
USE_PROXY("use.proxy", "false"),
PROXY_HOST("proxy.host", ""),
PROXY_PORT("proxy.port", ""),
PROXY_USERNAME("proxy.username", ""),
PROXY_PASSWORD("proxy.password", "");