search

Top-Ranger / harbour-vocabulary

Vocabulary is a vocabulary trainer for SailfishOS designed to be used independent of the language you want to learn.
Apache License 2.0
5 stars 6 forks source link

Use "Dialogs" for adding / edditing vocabulary #28

Open Top-Ranger opened 4 years ago

Top-Ranger commented 4 years ago

As suggested in https://github.com/Top-Ranger/harbour-vocabulary/pull/26, it would be nice to use Silica Dialogs for the adding / editing pages.

There were two reasons why I used a button in the original design:

  1. It made Error handling easier. I could abort the whole procedure and show an error message in case something went wrong. I have to check how this works with Silica Dialogs.
  2. In earlier versions saving was sometimes a bit slow. By using a button, the feedback to the user was a better (no stuck half-changed page). I don't think that's still a problem.

For me it is important that 1. still holds true (that is, in case of any error the page is still open and thus the input is not lost).

Since I don't know how to handle error cases without the dialogue closing in case of an error, help is welcomed.