Top-gg-Community / dotnet-sdk

MIT License
32 stars 11 forks source link

v1.4.5 GetVotersAsync method returns all user Ids as 0 #20

Closed ta1H3n closed 2 years ago

ta1H3n commented 3 years ago

Issue as per title.

Works perfectly in v1.4.0

faith-ie commented 3 years ago

huh, that's weird. I just double checked and I didn't even change anything on that method at all, other than codemaid changing whitespacing, it should be fine. Could I see some screenshots or something of it logging it as 0?

faith-ie commented 3 years ago

It just came to my mind that it might be an issue with System.Text.Json, ill double check it when I get a chance.

faith-ie commented 3 years ago

I think i found the issue and I'll roll out a fix for it later today / tomorrow / this weekend.

faith-ie commented 3 years ago

I think I might've fixed it, I'll leave the issue open in case I didn't.

velddev commented 3 years ago

Could you write a test with the setup System.Text.Json formatter?