Fix the library to work with .NET 5, and fix issue #20 and issue #23

Top-gg-Community / dotnet-sdk

MIT License

32 stars 11 forks source link

Fix the library to work with .NET 5, and fix issue #20 and issue #23 #24

Closed faith-ie closed 2 years ago

velddev commented 3 years ago

Few points before I will review it:

Please solve the spacing issues
Please state what actually fixed in the PR title.

faith-ie commented 3 years ago

1) unless you're mentioning a different spacing issue, I shiouldve pushed a fix already after I made this PR 2) fixed

velddev commented 3 years ago

It's hard for me to see what changed here:

faith-ie commented 3 years ago

i believe i might have changed the spacing issue, if it still is there, there is nothing I can really do as it's codemaid's fault that the spacing is weird.

velddev commented 2 years ago

Overall, this PR is rather massive for what it does, I would recommend not to mix a full-project reformat with 5 property changes as 90% of the PR review was me looking at code that was the same.