Weekend Update - Githubissues

Top-gg-Community / dotnet-sdk

MIT License

32 stars 11 forks source link

Weekend Update #3

Closed akulihin closed 6 years ago

akulihin commented 6 years ago

added "IsWeekendAsync", returns true if voting multiplier = x2
Fixed "GetVotersAsync" no longer required days parameter as it's obsolete, also, added created a throw exception if the bot has more than 1000 votes
Renamed "Score" to "Points"
added "IsWeekendAsync" unit test (passing)
added "GetVotersAsync" unit test (passing)
Changed naming "24h" to "12h" cooldown

tonkku107 commented 6 years ago

A throw is not needed when you have more than 1000 votes, you can still get the last 1000

akulihin commented 6 years ago

Removed Throw.

velddev commented 6 years ago

I'll look over the latest commits in an hour or two, travelling to my parents for a birthday party.

velddev commented 6 years ago

One thing I've noticed is that you set the authentication again in GetWeekendAsync, this shouldn't have to happen. Also consider using the serialised output instead of body.Contains

akulihin commented 6 years ago

Alright. I will remove authorization and change .Body.Contais later today or tomorrow

akulihin commented 6 years ago

HasVoted" have to be authorized.

IsWeekend is now a non-authorized method, also I moved it into DiscordBotListApi.cs
using "Deserialize" instead of ".Body.Contains()"