search

Top-gg-Community / java-sdk

An API wrapper for https://top.gg/api/docs that works in Java
Apache License 2.0
36 stars 22 forks source link

Fixes to comply with the new changes to the API #1

Closed RealGatt closed 6 years ago

nikammerlaan commented 6 years ago

Not a fan of the matchesUserID and matchesUserName methods. They aren't really relevant in the scope of this project.

nikammerlaan commented 6 years ago

Also -- the hasVoted() method means that it would be used as hasVoted(...).hasVoted() which seems really redundant. This does bring up a larger issue -- perhaps it's time to move away from Retrofit and get closer to the raw http requests.

nikammerlaan commented 6 years ago

I've decided to rewrite the library from scratch (mostly) instead of merging this.

RealGatt commented 6 years ago

No worries. My changes were mostly for personal use, ie; matchesUserID(). It was a bandaid fix and a learning opportunity for me to learn RetroFit.

Thanks for picking it back up.