search

Top-gg-Community / node-sdk

An official module for interacting with the Top.gg API
https://topgg.js.org/
133 stars 42 forks source link

Remove `APIOptions` #67

Closed BR88C closed 3 years ago

BR88C commented 3 years ago

As far as I can tell, APIOptions is unnecessary.

netlify[bot] commented 3 years ago

✔️ Deploy Preview for topgg-node-sdk-docs ready!

🔨 Explore the source changes: 7b4e9463a00412f634276b1129814094a0af6040

🔍 Inspect the deploy log: https://app.netlify.com/sites/topgg-node-sdk-docs/deploys/6102af2f1f6278000762a160

😎 Browse the preview: https://deploy-preview-67--topgg-node-sdk-docs.netlify.app/classes/api

jpbberry commented 3 years ago

This was created to allow for expandability in the library as there were a few options before and we might need it again, I can already think of a few as v1 comes through. This change would also be considered breaking, which is very unnecessary for something that doesn't add anything.

BR88C commented 3 years ago

Alright, makes sense. Closing