search

Top-gg-Community / node-sdk

An official module for interacting with the Top.gg API
https://topgg.js.org/
133 stars 42 forks source link

Remove unnecessary double slashes #69

Closed Pacmard closed 3 years ago

Pacmard commented 3 years ago

The request method already has a / in front of the PATH which is passed by other methods. Passing an additional slash at the beginning of the PATH for a request from a function is not required

netlify[bot] commented 3 years ago

✔️ Deploy Preview for topgg-node-sdk-docs ready!

🔨 Explore the source changes: 8845f29d7a5593ac1de5da3ff39471fbcee122ea

🔍 Inspect the deploy log: https://app.netlify.com/sites/topgg-node-sdk-docs/deploys/610ead99eed4da00078fc8d2

😎 Browse the preview: https://deploy-preview-69--topgg-node-sdk-docs.netlify.app

jpbberry commented 3 years ago

Make this the other way around. I prefer the / be at the beginning when using the request method because it looks like a path. You just have to remove the existing / from the existing request method. e.g .request(“GET”, “/bot/stats”)

Pacmard commented 3 years ago

Understandable, done