search

Top-gg-Community / node-sdk

An official module for interacting with the Top.gg API
https://topgg.js.org/
132 stars 42 forks source link

Undocumented constructor overloads #9

Closed ZLima12 closed 6 years ago

ZLima12 commented 6 years ago

It seems like the constructor for the DBLAPI class has an undocumented overload: the client object can be passed in the options place.

https://github.com/DiscordBotList/dblapi.js/blob/5f70adaf2d0c6842341eda8bd5d9d14ff7ac929e/src/index.js#L28-L31

Is this still desired? If so, I'll update the typings. It would be wise to update the documentation as well.

tonkku107 commented 6 years ago

The documentation does contain it

ZLima12 commented 6 years ago

Oh, I see now. It wasn't as clear as I had thought it might be. In that case I'll update the typings.

ZLima12 commented 6 years ago

2018-04-25-082101_1916x1041_scrot Maybe something like this would be possible? Just to be as clear as possible.

tonkku107 commented 6 years ago

Added that in the latest docs