search

Top-gg-Community / python-sdk

A simple API wrapper for top.gg written in Python
https://docs.top.gg/docs/Libraries/python
MIT License
90 stars 54 forks source link

Allow getting data by subclasses #68

Open norinorin opened 2 years ago

norinorin commented 2 years ago

Proposed Changes

Allow getting data by subclasses. The time complexity is supposedly O(n) on the first lookup and O(1) afterwards as the first result got cached.

norinorin commented 2 years ago

LGTM (but I don't see the point. This might also be a breaking change)

You're not wrong, I kinda had a use case but I don't think it's practical (that's why this is still a draft). Though don't worry about the breaking change, we're indeed doing breaking changes. We've bumped the major version and it's still alpha anyway.

Esmeray6 commented 5 months ago

@norinorin Do you plan on advancing further with this PR by any chance?

norinorin commented 2 months ago

Sorry I missed your comment. It's been a few years, and I don't remember the specifics of this PR (had to be related to one of my local projects). I must've left it in a usable state but forgot to remove the draft status.

Feel free to merge it or close it as you see fit, if there is even an active maintainer that is.