search

Top-gg-Community / python-sdk

A simple API wrapper for top.gg written in Python
https://docs.top.gg/docs/Libraries/python
MIT License
91 stars 54 forks source link

Update aiohttp constraints #74

Open No767 opened 1 year ago

No767 commented 1 year ago

With aiohttp releasing 3.9.0, which supports 3.12, we need to update the current constraints

Fixes #

Proposed Changes

-

-

No767 commented 1 year ago

ping @Esmeray6

Esmeray6 commented 1 year ago

ping @Esmeray6

Ping someone from the top.gg team (if someone actually cares to look into these 🙃).

I don't maintain the library anymore. Or did you just want a second pair of eyes?

No767 commented 1 year ago

ping @Esmeray6

Ping someone from the top.gg team (if someone actually cares to look into these 🙃).

I don't maintain the library anymore. Or did you just want a second pair of eyes?

I'll take care of maintaining the library if you want me to do so. I'll contact the topgg team if they are able to merge this pr

Esmeray6 commented 1 year ago

If nothing has changed by now, you'll have to run your changes through someone from the team (no collaborator permissions, you just create PRs and the team merges them).

My wonder is whether anyone from the team will bother with this library after... 3? years of no updates to this repo.

With this said, it's entirely up to you.

No767 commented 1 year ago

If nothing has changed by now, you'll have to run your changes through someone from the team (no collaborator permissions, you just create PRs and the team merges them).

True, but this PR doesn't really have any changes. The updated requirements for aiohttp follow the same exact requirements as discord.py's aiohttp version requirements. I'll try and ask someone on the team if I can help out

Esmeray6 commented 1 year ago

It's more about the fact that maintainers, as far as I recall (3 years ago, give or take), don't have write access to the repositories. So, they're simply stuck with waiting for whoever to review the changes and accept the PRs. Correct me if that's changed at any point after that.

Nevertheless, I'm just ranting off-topic at this point. My apologies.

Esmeray6 commented 9 months ago

@No767 Additionally if you still want to maintain this library, I would prefer to be contacted by someone from the staff to transfer ownership of the PyPi package.

No767 commented 9 months ago

@Esmeray6 Sure

Esmeray6 commented 8 months ago

Any update on this?

Esmeray6 commented 7 months ago

This PR is overwritten by #74, can be closed if that gets merged.