Closed kmohrman closed 2 years ago
Merging #302 (d4d3078) into master (495f8b8) will decrease coverage by
3.57%
. The diff coverage is17.85%
.
@@ Coverage Diff @@
## master #302 +/- ##
==========================================
- Coverage 28.09% 24.51% -3.58%
==========================================
Files 46 46
Lines 7034 7061 +27
==========================================
- Hits 1976 1731 -245
- Misses 5058 5330 +272
Flag | Coverage Δ | |
---|---|---|
unittests | 24.51% <17.85%> (-3.58%) |
:arrow_down: |
Flags with carried forward coverage won't be shown. Click here to find out more.
Impacted Files | Coverage Δ | |
---|---|---|
topcoffea/modules/utils.py | 20.97% <5.55%> (-2.23%) |
:arrow_down: |
analysis/topEFT/make_cards.py | 58.64% <40.00%> (-1.49%) |
:arrow_down: |
topcoffea/modules/get_renormfact_envelope.py | 0.00% <0.00%> (-75.95%) |
:arrow_down: |
topcoffea/modules/corrections.py | 0.00% <0.00%> (-35.47%) |
:arrow_down: |
topcoffea/modules/objects.py | 0.00% <0.00%> (-20.88%) |
:arrow_down: |
topcoffea/modules/selection.py | 0.00% <0.00%> (-6.96%) |
:arrow_down: |
topcoffea/modules/GetValuesFromJsons.py | 32.14% <0.00%> (-3.58%) |
:arrow_down: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 495f8b8...d4d3078. Read the comment docs.
Add a check to the data card maker wrapper to raise and error if the list of selected WCs does not match the reference. Note this is not really the best way to handle this check (would be better to check against the one in the EFTFit repo, but that's harder) but at least should be better than nothing.