search

TopEFT / topeft

15 stars 24 forks source link

Using UL16APV SFs for Ul16 for light flav #322

Closed kmohrman closed 2 years ago

kmohrman commented 2 years ago

For UL16, we swap in the UL16APV SFs for the light flavor jets (to work around a UL16 issue, same approach as ttbb analysis here).

codecov[bot] commented 2 years ago

Codecov Report

Merging #322 (77cdb10) into master (752826c) will decrease coverage by 13.90%. The diff coverage is 0.00%.

@@             Coverage Diff             @@
##           master     #322       +/-   ##
===========================================
- Coverage   37.98%   24.07%   -13.91%     
===========================================
  Files          47       47               
  Lines        7240     7251       +11     
===========================================
- Hits         2750     1746     -1004     
- Misses       4490     5505     +1015
Flag Coverage Δ
unittests 24.07% <0.00%> (-13.91%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
topcoffea/modules/corrections.py 0.00% <0.00%> (-85.23%) :arrow_down:
topcoffea/modules/selection.py 0.00% <0.00%> (-90.38%) :arrow_down:
topcoffea/modules/objects.py 0.00% <0.00%> (-80.22%) :arrow_down:
analysis/topEFT/topeft.py 9.40% <0.00%> (-72.87%) :arrow_down:
topcoffea/modules/get_renormfact_envelope.py 0.00% <0.00%> (-13.93%) :arrow_down:
topcoffea/modules/dataDrivenEstimation.py 69.16% <0.00%> (-4.17%) :arrow_down:
topcoffea/modules/GetValuesFromJsons.py 32.14% <0.00%> (-3.58%) :arrow_down:
topcoffea/modules/utils.py 20.97% <0.00%> (-2.80%) :arrow_down:
topcoffea/modules/HistEFT.py 61.98% <0.00%> (-0.24%) :arrow_down:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

kmohrman commented 2 years ago

Thanks @andrea21z for taking a look at this PR. Before we merge, @bryates did you want to check over the updates as well (since you were the one who spotted that the workaround was missing for the systematics)?