search

TopEFT / topeft

15 stars 24 forks source link

Updated tllq PDF and QCD systs #328

Closed bryates closed 1 year ago

bryates commented 1 year ago

Numbers take from TOP-20-010 -> TOP-16-020 -> MadGraph 94.2 +1.9-1.8 (scale) +/- 2.5 (PDF)

codecov[bot] commented 1 year ago

Codecov Report

Merging #328 (22a55af) into master (3b78eb0) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #328   +/-   ##
=======================================
  Coverage   30.45%   30.45%           
=======================================
  Files          47       47           
  Lines        7538     7538           
=======================================
  Hits         2296     2296           
  Misses       5242     5242
Flag Coverage Δ
unittests 30.45% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

kmohrman commented 1 year ago

Looks good to me, I will go ahead and merge once the CI finishes.

kmohrman commented 1 year ago

@bryates it looks like the CI failed. Also it seems the 5% conversions systematic has been added back in in the most recent commit, was that unintentional?

bryates commented 1 year ago

@bryates it looks like the CI failed. Also it seems the 5% conversions systematic has been added back in in the most recent commit, was that unintentional?

The CI failed because WQ ran out of time. I reran it to make sure it was just a fluke. I've removed the conversions 5% again, it popped back in after I messed up a pull earlier.

bryates commented 1 year ago

@bryates it looks like the CI failed. Also it seems the 5% conversions systematic has been added back in in the most recent commit, was that unintentional?

The CI failed because WQ ran out of time. I reran it to make sure it was just a fluke. I've removed the conversions 5% again, it popped back in after I messed up a pull earlier.

It passes now.