TopEFT / topeft

15 stars 24 forks source link

Rewrite and/or remove the `topcoffea/modules/YeldsTools.py` script #342

Open kmohrman opened 1 year ago

kmohrman commented 1 year ago

This script is currently mainly unused. It was originally written to facilitate yield comparisons, especially by the CI. Some of its functions are still used for this purpose. However, the script is very messy and very ad-hoc. The script was also written at a time when its author (@kmohrman) was very unfamiliar with coffea (so, much of it is written in a very non-optimal way). Furthermore, at this point, most of its original functionality is no longer used.

It would make the CI yield checks much easier to maintain and develop it it were based on a smaller and more efficient script.

For these reasons, this lengthy script should be examined in order to remove the unused parts. Alternatively, it may be more efficient to throw out the script entirely, and simply write a much smaller and much for efficient script to perform the yield checks required by the CI.