Check if coffea Hist is depreciated

TopEFT / topeft

15 stars 24 forks source link

Check if coffea Hist is depreciated #345

Closed bryates closed 1 year ago

kmohrman commented 1 year ago

Just to add some description to this issue, it would be good to know the following:

On what date does (or did) coffea hist officially become depreciated, i.e. no longer supported or updated
On what date does the warning about the depreciation change to an error
What are the immediate consequences for topcoffea (e.g. do we expect the CI to start failing?)
If the consequences inhibit our ability to run (e.g. if the warning becomes and error and the processor crashes) then we should implement at least a temporary workaround (e.g. pinning the coffea version, or copying the coffea hist code to topeft and maintaining it privately until we can upgrade)

abasnet97 commented 1 year ago

@kmohrman, based on this migration guide, I think for v0.8.0, coffea hist has already been switched to an error.

kmohrman commented 1 year ago

Then I am wondering if you or @emcgrady understand why our CI continues to run fine without crashing?

abasnet97 commented 1 year ago

Hmm good point. Maybe Dec 2022 was the target date for coffea v0.8.0 release but perhaps got pushed back. Not sure!

abasnet97 commented 1 year ago

Based on a recent message posted by Lindsey Gray (one of the coffea developers) on Coffea Users Mattermost channel (March 14, 2023), coffea 2023 (which was initially called v0.8) is still a work in progress and nearing completion soon. That might be why we still have our CI passing.

abasnet97 commented 1 year ago

Update: Based on Lindsey's recent message on Coffea Users Mattermost channel (on Apr 6, 2023), it seems like a first release candidate of coffea 2023 is out now. The caveat is that it is only on pypi for now (won't be on conda until full release).

kmohrman commented 1 year ago

Coffea hist is indeed out of date. HistEFT will be replaced by histEFT see PR#371